2 Comments       5 Reposts       2 QuoteReposts       5 Reposts       15 Likes       27 Diamonds
Comments (work-in-progress)
@SeanSlater - Jan 28, 2023
Nice one @JohnJardin - can you expand on "We reproduced the issue and identified minor inconsistencies with the Hodler profile data returned via the DeSo APIs."

What were the issues?
diamonds: 5   likess: 2
@JohnJardin - Jan 28, 2023
The API - https://desocialworld.com/api/v0/get-hodlers-for-public-key - for DAO Coin holders returned a profile for one of the DeSo user accounts that didn't contain a property "ProfileEntryResponse." - This happened to @NodeRunner's @NodeBitsDAO account. The profile record landed up belonging to NodeBitsDAO, which should be ignored for my logic. Therefore, I now check for each returned profile to contain a ProfileEntryResponse prop because I rely on data within that object. Here's the git commit where I resolved the issue: https://github.com/agilitehub/desoops-portal/commit/a9619f36d14ad913d952f1e26f75cbd50c6e2047
diamonds: 9   likess: 1
@SeanSlater - Jan 28, 2023
Ahh yep, I discovered that one myself when building the @DeSoShopping distribution script.
diamonds: 3   likess: 1
@JohnJardin - Jan 28, 2023
Any chance you understand more of what's happening there than I do?
diamonds: 4   likess: 0
@SeanSlater - Jan 28, 2023
I can't remember off the top of my head, but can go look at the code to remind myself tomorrow and let you know.
diamonds: 4   likess: 1
@JohnJardin - Jan 28, 2023
Shame don't worry about it, Sean. I was just curious if you knew off the top of your head.
diamonds: 1   likess: 0
@NodeRunner - Jan 28, 2023
Thank you for the prompt fix!
diamonds: 3   likess: 1